Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Image display error in the Rio terminal. #1786

Closed
Kevin-2483 opened this issue Oct 15, 2024 · 6 comments
Closed

Image display error in the Rio terminal. #1786

Kevin-2483 opened this issue Oct 15, 2024 · 6 comments
Labels
invalid This doesn't seem right

Comments

@Kevin-2483
Copy link

What system are you running Yazi on?

macOS

What terminal are you running Yazi in?

rio

yazi --debug output

Yazi
    Version: 0.3.3 (Nixpkgs 2024-09-04)
    Debug  : false
    OS     : macos-aarch64 (unix)

Ya
    Version: 0.3.3 (Nixpkgs 2024-09-04)

Emulator
    Emulator.via_env: ("rio", "rio")
    Emulator.via_csi: Ok(Unknown([Sixel]))
    Emulator.detect : Unknown([Sixel])

Adapter
    Adapter.matches: Sixel

Desktop
    XDG_SESSION_TYPE           : None
    WAYLAND_DISPLAY            : None
    DISPLAY                    : None
    SWAYSOCK                   : None
    HYPRLAND_INSTANCE_SIGNATURE: None
    WAYFIRE_SOCKET             : None

SSH
    shared.in_ssh_connection: false

WSL
    WSL: false

Variables
    SHELL              : Some("/bin/zsh")
    EDITOR             : Some("lvim")
    VISUAL             : None
    YAZI_FILE_ONE      : None
    YAZI_CONFIG_HOME   : None

Text Opener
    default: Some(Opener { run: "lvim \"$@\"", block: true, orphan: false, desc: "Open with lunarVim", for_: None, spread: true })
    block  : Some(Opener { run: "lvim \"$@\"", block: true, orphan: false, desc: "Open with lunarVim", for_: None, spread: true })

Multiplexers
    TMUX               : false
    tmux version       : tmux 3.5a
    ZELLIJ_SESSION_NAME: None
    Zellij version     : No such file or directory (os error 2)

Dependencies
    file             : 5.45
    ueberzugpp       : No such file or directory (os error 2)
    ffmpegthumbnailer: 2.2.2
    magick           : 7.1.1-39
    fzf              : 0.55.0
    fd               : 10.2.0
    rg               : 14.1.1
    chafa            : 1.14.4
    zoxide           : 0.9.6
    7z               : 17.05
    7zz              : 24.08
    jq               : 1.7.1


--------------------------------------------------

Did you try the latest nightly build to see if the problem got fixed?

Yes, and I updated the debug information above (yazi --debug) to the nightly that I tried

Describe the bug

2024-10-15.22.38.48-3.mov

When running Yazi in Rio, the images displayed will remain in the terminal and cannot be removed. Sometimes, they overlap with each other, and text can overlap on top of the images. On the same computer, it works normally in Kitty. A video demonstrates the behavior of Rio.”

Minimal reproducer

  • macos 15.0.1
  • rioterm 0.1.17
  • yazi 0.3.3

they are all in nixpkgs-unstable

Anything else?

No response

@Kevin-2483 Kevin-2483 added the bug Something isn't working label Oct 15, 2024
@sxyazi
Copy link
Owner

sxyazi commented Oct 15, 2024

I can reproduce the issue on Rio, but using the same Inline Image Protocol code, I couldn't replicate it on any other terminal emulator (iTerm2, WezTerm, Tabby).

Given that Rio only recently added support for the image rendering, this is likely an issue specific to Rio itself, which will require some debugging on the terminal emulator's side. I suggest filing an issue to request their support.

I'll also create a PR later to update the README, mentioning the issue with images not being properly cleared on Rio. Closing as not Yazi

@sxyazi sxyazi closed this as not planned Won't fix, can't repro, duplicate, stale Oct 15, 2024
@sxyazi sxyazi added invalid This doesn't seem right and removed bug Something isn't working labels Oct 15, 2024
@sxyazi
Copy link
Owner

sxyazi commented Oct 15, 2024

I'll also create a PR later to update the README, mentioning the issue with images not being properly cleared on Rio. Closing as not Yazi

Done in https://github.com/sxyazi/yazi/pull/1784/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5

@Kevin-2483
Copy link
Author

I’m afraid Tabby can’t be used either. When I tested it today, the images were enlarged significantly, and the terminal text disappeared.

image

@sxyazi
Copy link
Owner

sxyazi commented Oct 16, 2024

When I tested it today, the images were enlarged significantly

This is expected behavior, Tabby doesn't implement the ioctl system call, you need to tune down max_width and max_height manually.

Already mentioned in https://yazi-rs.github.io/docs/image-preview#size, please read docs carefully

@raphamorim
Copy link
Contributor

Thank you for the issue report and @sxyazi for the update on it. I will take a look on a fix for it 🙏

Copy link

I'm going to lock this issue because it has been closed for 30 days. ⏳
This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please file a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 16, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

3 participants