New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

ComposerScriptsConfigurator can break "composer.json" filename in patch #1010

Open

klkvsk opened this issue Feb 8, 2024 · 0 comments · May be fixed by #1011

klkvsk commented Feb 8, 2024 •

edited

Loading

flex/src/Configurator/ComposerScriptsConfigurator.php

Line 52 in bec213c

    
           $jsonPath = ltrim(str_replace($recipeUpdate->getRootDir(), '', $json->getPath()), '/\\');

In case when root dir = ".", it replaces the dot in filename, and then applying the patch is broken with:

NOTE:
  The file composerjson was not updated because it doesn't exist in your app.

Reported in symfony/recipes#1271

The text was updated successfully, but these errors were encountered:

klkvsk linked a pull request

that will close this issue

fix jsonPath in ComposerScriptsConfigurator::update #1011

Open

# for free to join this conversation on GitHub. Already have an account? # to comment