Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Dependency error as friendly-errors-webpack-plugin still requires webpack 4 #922

Closed
MiMo42 opened this issue Feb 8, 2021 · 6 comments · Fixed by #976
Closed

Dependency error as friendly-errors-webpack-plugin still requires webpack 4 #922

MiMo42 opened this issue Feb 8, 2021 · 6 comments · Fixed by #976

Comments

@MiMo42
Copy link

MiMo42 commented Feb 8, 2021

webpack-encore 1.0.5 requires webpack "^5.12"
AND
friendly-errors-webpack-plugin "^2.0.0-beta.1"

BUT: friendly-errors-webpack-plugin requires webpack "^4.0.0"

That gives me:

npm WARN ERESOLVE overriding peer dependency
npm WARN Found: webpack@5.21.2
npm WARN node_modules/webpack
npm WARN   webpack@"^5.12" from @symfony/webpack-encore@1.0.5
npm WARN   node_modules/@symfony/webpack-encore
npm WARN     dev @symfony/webpack-encore@"^1.0.0" from the root project
npm WARN   9 more (browser-sync-webpack-plugin, postcss-loader, ...)
npm WARN 
npm WARN Could not resolve dependency:
npm WARN peer webpack@"^4.0.0" from friendly-errors-webpack-plugin@2.0.0-beta.2
npm WARN node_modules/friendly-errors-webpack-plugin
@Kocal
Copy link
Member

Kocal commented Feb 8, 2021

Hi, an issue (geowarin/friendly-errors-webpack-plugin#123) and a PR has already be opened (geowarin/friendly-errors-webpack-plugin#126).

There is not much we can do here, just waiting... 😅

@weaverryan
Copy link
Member

I have also considered embedding the plugin, which would super unfortunate, as the plugin DOES work in webpack 5 just fine.

@ppatrik
Copy link

ppatrik commented Apr 18, 2021

Is there any workaround for this issue? friendly-errors-webpack-plugin project repository looks like dead with last release in 2018 and last commit 16 months ago.

@hailwood
Copy link
Contributor

hailwood commented May 7, 2021

@weaverryan would @nuxt/friendly-errors-webpack-plugin work?

@weaverryan
Copy link
Member

@hailwood oh, indeed it would! It looks popular and well-maintained. It is a fork of the original... though it looks like 1.6.1 was the last shared version. We use 2.0.0-beta.2, so there could be some BC breaks. However, staying on what we have no is a non-option.

Short answer: yes, we should change to this. Would someone be willing to give it a try?

@hailwood
Copy link
Contributor

@weaverryan boom! #976

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
5 participants