Skip to content
This repository was archived by the owner on Jan 26, 2021. It is now read-only.

Added Selenium tests #357

Merged
merged 5 commits into from
Jul 13, 2016
Merged

Added Selenium tests #357

merged 5 commits into from
Jul 13, 2016

Conversation

smarshy
Copy link
Contributor

@smarshy smarshy commented Jul 12, 2016

This PR is to add remaining tests from last week as well as the tests for this week. I am putting a separate PR so that it is easier to review. The tests include -

  • test for job details
  • 3 tests for shift details view (due to 3 test situations : when no volunteers are registered for a shift, when volunteers are registered but haven't logged hours and when hours are logged)
  • 3 tests for checking that values in event, shift and job form are not lost when the page reloads
  • test for checking if a shift can have 0 volunteers (validating max volunteer field)
  • test to check that logged hours fall between the shift hours
  • test for simplify shift

In addition to this, there are 3 more tests which have been commented out:

  • 2 tests for checking that event is unique and job within event is unique. These have been commented out as the feature hasn't been implemented yet ( Job name inside an event should be unique #330 and Events name has to be unique #329 )
  • test for simplify job (This test is not passing; I think the reason is because the js script is not updating the date in the form. i tried increasing delay but it sill doesn't seem to work)

Total tests that would run are 160 ( 150 original + 10 new + 3 commented out)
Related to issue #346

@coveralls
Copy link

coveralls commented Jul 12, 2016

Coverage Status

Coverage decreased (-11.4%) to 82.78% when pulling 18ba8f2 on smarshy:selTest into 123f69b on systers:develop.

@tapaswenipathak tapaswenipathak merged commit 4436a63 into anitab-org:develop Jul 13, 2016
@smarshy smarshy deleted the selTest branch August 4, 2016 23:25
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants