-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Feature: Return a histogram for response time #43
Comments
Nice job! 😃 |
Hi @remeika , do you have an update on that feature? would be nice to test it |
I just realize that the average can be very misleading: When you look at the individual timeseries, things are okayish - they might just gloss over some (e.g very slow) requests. Moreover, I don't think the proposed design works either since the VTS data structure is also just sampled, so you again miss some requests and you can't compare two upstreams. I think the only way to properly solve this is histogram buckets in nginx, e.g each request needs to be counted into one bucket. |
Ping @BertHartm |
Any development already in place here? Also, very interested in this feature :-) |
I don't think this is possible with the current state of the vts module, it would have to be implemented there. |
This exporter should have the option to expose response times as a histogram, rather than a simple average. The dataset to support this feature is already available in the
upstreamZones. requestMsecs.msecs
data structure from VTS.Proposed Interface: An optional command line flag
-nginx.response.histogram_buckets
is added, and takes a comma separated list of integers as an argument. When declared, two additional metrics are implemented:{NAMESPACE}_filter_responses
and{NAMESPACE}_upstream_responses
. They are both histograms with bucket sizes from the input flag.Note: I am actively building feature; any comments on the interface please let me know!
The text was updated successfully, but these errors were encountered: