Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

git submodule for IR_precision #43

Closed
zbeekman opened this issue Jun 30, 2015 · 7 comments
Closed

git submodule for IR_precision #43

zbeekman opened this issue Jun 30, 2015 · 7 comments

Comments

@zbeekman
Copy link
Contributor

It might make sense to use a git submodule for IR_precision rather than duplicating the source into this project and your others. Git submodules can be a little bit confusing at first, but poor Fortran people can be taught how to use them, I think.

@szaghi
Copy link
Owner

szaghi commented Jun 30, 2015

@zbeekman

:-)

You are right (and not the first to advice me... @victorsndvg I am studying your setup...).

ASAP, I will integrate git submodules into my workflow :-)

@zbeekman
Copy link
Contributor Author

If you want me to take a crack at it and submit a PR, let me know. It shouldn’t take long.

@szaghi
Copy link
Owner

szaghi commented Jun 30, 2015

@zbeekman Feel free to do anything you consider useful, all your PR are always welcome.

However, for this specific case I have a dubt (that blocks me to use submodule in all my publuc projects): is possible to submodularize just one file of a remote repo? If not, the ir_precision module should be submodularized smartly...

@zbeekman
Copy link
Contributor Author

yes, as far as I know you need to use the whole repo not just one file. You can use a symbolic link to simplify the structure though, and keep it similar to how it is now. Or adapt the fobos file to account for the new structure.

@szaghi
Copy link
Owner

szaghi commented Jul 28, 2015

Done in the version 0.6.3.

Submodules are placed into external and the necessary sources are symlinked from here
to the main project src directory.

@szaghi szaghi closed this as completed Jul 28, 2015
@victorsndvg
Copy link

Hello @szaghi ,

sorry for my ignorance, but I've seen your recent changes related with this issue and it's the first time that I see symbolic links in git.

It is a git feature or an usual symbolic link?

@szaghi
Copy link
Owner

szaghi commented Jul 28, 2015

Hi victor, it is a usual sym link. Git can handle the type of file and it recognizes that this is a sym link.

I will working on Lib_VTK_IO in my break today...

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

3 participants