You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jan 20, 2021. It is now read-only.
Proposed fix: build a frame that encloses all the characters in the target area, and use it to clip all the rulings inside it. This, in fact, can be done whether the spreadsheet has a bounding frame or not.
The text was updated successfully, but these errors were encountered:
I implemented this by building the frame to enclose all ruling lines in the target area -- rather than characters. My alternative is more likely to work in all cases for the spreadsheet algorithm, which depends on lines intersecting (or very nearly intersecting).
Is there a case in which building the frame using characters is superior? Unless I'm mistaken, the "original" method would ignore the frame no matter what, right?
My solution (33abbdb) causes test_issue78_some_ruling_lines_not_detected to fail. I think the failure is due to a typo fixed in f16eb31 and the new, actual result is a proper result (it basically returns an additional row).
(as commented in jazzido/tabula#128)
There are spreadsheets with no outer frame.
Proposed fix: build a frame that encloses all the characters in the target area, and use it to clip all the rulings inside it. This, in fact, can be done whether the spreadsheet has a bounding frame or not.
The text was updated successfully, but these errors were encountered: