Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove irrelevant dependency on the module typing #25

Open
moste00 opened this issue Apr 11, 2024 · 0 comments
Open

Remove irrelevant dependency on the module typing #25

moste00 opened this issue Apr 11, 2024 · 0 comments

Comments

@moste00
Copy link
Collaborator

moste00 commented Apr 11, 2024

This module started being included in Python from version 3.5, its PyPI page (https://pypi.org/project/typing/) explicitly says that installing it in any Python from 3.5 onwards has 0 effects. The reason this dependency is annoying is - in addition to cluttering the requirements.txt - it makes Pyinstaller choke and fail for some reason. We rely on Pyinstaller in the CI to produce the static binaries we publish to the Releases. The temporary workaround to this that the CI currently makes is running pip uninstall -y typing before invoking Pyinstaller, but this is an ugly and unnecessary hack.

The PR that will close this issue will:

  • Remove typing from requirements.txt
  • Ensure that neither the dev experience nor the user experience has degraded
  • Modify the CI files to remove the pip uninstall
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant