Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

no package-lock.json but yarn.lock #338

Closed
DanielRuf opened this issue Dec 26, 2017 · 3 comments
Closed

no package-lock.json but yarn.lock #338

DanielRuf opened this issue Dec 26, 2017 · 3 comments

Comments

@DanielRuf
Copy link
Contributor

Is it intended to just have a yarn.lock file and no package-lock.json file?

@DanielRuf DanielRuf changed the title no packa-lock.json but yarn.lock no package-lock.json but yarn.lock Dec 26, 2017
@julienbourdeau
Copy link

It seems pretty hard to maintain the 2 in sync in the repo. Am I missing something?

@DanielRuf
Copy link
Contributor Author

@adamwathan
Copy link
Member

The recommendation from the Yarn team is to commit lock files even for libraries:

https://yarnpkg.com/blog/2016/11/24/lockfiles-for-all/

I personally use Yarn and not NPM which is why there happens to not be a package-lock.json file. I'm not sure if there's a recommended workflow out there for maintaining both and keeping them up to date though.

Open to suggestions or opinions on best practices here, but going to close this as an "issue" and just leave it open for discussion.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants