Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Clean up the plugin #317

Open
julianwachholz opened this issue Feb 6, 2015 · 1 comment
Open

Clean up the plugin #317

julianwachholz opened this issue Feb 6, 2015 · 1 comment

Comments

@julianwachholz
Copy link

Right now the plugin is one gigantic 4000+ LOC file. This is certainly not easy to edit let alone makes it easy to attract new developers.

Furthermore any changes could possibly break some completely unrelated part of the plugin if you don't pay close attention to the architecture.

The plugin.py file should definitely be split up into separate modules for easier maintenance and lower learning curve for new contributors.

@brrr2
Copy link
Collaborator

brrr2 commented Feb 7, 2015

The code needs a lot of cleaning up in general. This should be done incrementally. While I agree that splitting up plugin.py into several files is a sensible thing to do, it wouldn't follow the structure of other Supybot/Limnoria plugins. It's a much more complex plugin than others, which is why there are so many lines of code. However, with a bit of restructuring within plugin.py, I think it would greatly improve the readability of the code.

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

3 participants