Merge pull request #34 from tattersoftware/serial

Bundle Caching

Author: MGatner

src/Bundle.php

@@ -176,4 +176,30 @@ private function toString(?bool $head = null): string
 
         return implode(PHP_EOL, $lines);
     }
+
+    //--------------------------------------------------------------------
+    // Caching
+    //--------------------------------------------------------------------
+
+    /**
+     * Prepares the bundle for caching.
+     *
+     * @return Asset[]
+     */
+    public function __serialize(): array
+    {
+        return $this->getAssets();
+    }
+
+    /**
+     * Restores the bundle from cached version.
+     *
+     * @param Asset[] $data
+     */
+    public function __unserialize(array $data): void
+    {
+        foreach ($data as $asset) {
+            $this->add($asset);
+        }
+    }
 }

src/RouteBundle.php

@@ -62,26 +62,4 @@ public static function createFromRoute(string $uri): self
 
         return $bundle;
     }
-
-    /**
-     * Prepares the bundle for caching.
-     *
-     * @return Asset[]
-     */
-    public function __serialize(): array
-    {
-        return $this->getAssets();
-    }
-
-    /**
-     * Prepares the bundle for caching.
-     *
-     * @param Asset[] $data
-     */
-    public function __unserialize(array $data): void
-    {
-        foreach ($data as $asset) {
-            $this->add($asset);
-        }
-    }
 }

tests/BundleTest.php

@@ -12,7 +12,7 @@ final class BundleTest extends AssetsTestCase
 {
     public function testConstructorPaths()
     {
-        $bundle              = new class() extends Bundle {
+        $bundle              = new class () extends Bundle {
             protected $paths = ['apple.css'];
         };
 
@@ -25,7 +25,7 @@ public function testConstructorPaths()
 
     public function testConstructorBundles()
     {
-        $bundle                = new class() extends Bundle {
+        $bundle                = new class () extends Bundle {
             protected $bundles = [FruitSalad::class];
         };
 
@@ -38,7 +38,7 @@ public function testConstructorBundles()
 
     public function testConstructorStrings()
     {
-        $bundle                = new class() extends Bundle {
+        $bundle                = new class () extends Bundle {
             protected $strings = ['foobar'];
         };
 
@@ -51,7 +51,7 @@ public function testConstructorStrings()
 
     public function testStringable()
     {
-        $asset               = new class() extends Bundle {
+        $asset               = new class () extends Bundle {
             protected $paths = ['apple.css'];
         };
 
@@ -60,7 +60,7 @@ public function testStringable()
 
     public function testHead()
     {
-        $asset               = new class() extends Bundle {
+        $asset               = new class () extends Bundle {
             protected $paths = [
                 'apple.css',
                 'banana.js',
@@ -69,4 +69,13 @@ public function testHead()
 
         $this->assertSame('<link href="http://example.com/assets/apple.css" rel="stylesheet" type="text/css" />', $asset->head());
     }
+
+    public function testSerializing()
+    {
+        $bundle = new FruitSalad();
+
+        $result = unserialize(serialize($bundle));
+
+        $this->assertSame($bundle->body(), $result->body());
+    }
 }

tests/RouteBundleTest.php

@@ -1,6 +1,5 @@
 <?php
 
-use Tatter\Assets\Asset;
 use Tatter\Assets\Exceptions\AssetsException;
 use Tatter\Assets\RouteBundle;
 use Tests\Support\AssetsTestCase;
@@ -103,15 +102,4 @@ public function testCreateFromRouteThrowsInvalidType()
 
         RouteBundle::createFromRoute('invalid');
     }
-
-    public function testSerializing()
-    {
-        $asset1 = new Asset('banana');
-        $asset2 = new Asset('bread', false);
-        $bundle = (new RouteBundle())->add($asset1)->add($asset2);
-
-        $result = unserialize(serialize($bundle));
-
-        $this->assertSame($bundle->body(), $result->body());
-    }
 }