Skip to content
This repository was archived by the owner on Jan 25, 2022. It is now read-only.

Unused privateName in spec #290

Closed
legendecas opened this issue Jan 19, 2020 · 5 comments · Fixed by #291
Closed

Unused privateName in spec #290

legendecas opened this issue Jan 19, 2020 · 5 comments · Fixed by #291

Comments

@legendecas
Copy link
Member

https://tc39.es/proposal-class-fields/#runtime-semantics-class-definition-evaluation

Step 2.12.2.8.a.ii created a privateName yet is not used afterwards. It may be used at 2.12.2.8.a.iii since the step is Perform ! classPrivateEnvRec.InitializeBinding(dn, dn)., in which InitializeBinding might accept the name and an initializer, but in the spec two identical dn are used.

@legendecas legendecas changed the title Used privateName in spec Unused privateName in spec Jan 19, 2020
@littledan
Copy link
Member

Good catch. This should be InitializeBinding(dn, privateName).

Is anyone interested in making a PR to correct the typo?

@ljharb
Copy link
Member

ljharb commented Jan 22, 2020

I can't find this error in any of the three spec PRs (tc39/ecma262#1655, tc39/ecma262#1667, tc39/ecma262#1668); perhaps it's been fixed in those already?

@legendecas
Copy link
Member Author

legendecas commented Jan 23, 2020

I can't find this error in any of the three spec PRs (tc39/ecma262#1655, tc39/ecma262#1667, tc39/ecma262#1668); perhaps it's been fixed in those already?

IIUC this proposal has not been merged into ecma262 yet.

@legendecas
Copy link
Member Author

I can't find this error in any of the three spec PRs (tc39/ecma262#1655, tc39/ecma262#1667, tc39/ecma262#1668); perhaps it's been fixed in those already?

Step 2.12.2.8.a.ii and 2.12.2.8.a.iii are missing in tc39/ecma262#1655 yet presented in https://tc39.es/proposal-class-fields/#runtime-semantics-class-definition-evaluation.

@ljharb
Copy link
Member

ljharb commented Jan 23, 2020

@legendecas they haven’t been merged, but those three open PRs represent what will be merged eventually. If there’s something missing, please comment on it with specifics :-)

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants