Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Consider removing GetModuleSource() #68

Closed
guybedford opened this issue Nov 30, 2024 · 1 comment
Closed

Consider removing GetModuleSource() #68

guybedford opened this issue Nov 30, 2024 · 1 comment

Comments

@guybedford
Copy link
Collaborator

Now that ESM Phase Imports have implemented an explicit [[ModuleSource]] internal field on module records, it may be possible to just define this field upfront for all module records that want to provide their source phase.

Error customization for module sources that don't expose this phase could be as simple as "Module source kind X doesn't implement the source phase", as opposed to needing these being custom completions.

I believe this change can be considered editorial as part of the Stage 4 process for this spec, but this needs to be discussed further.

@guybedford
Copy link
Collaborator Author

Landed in #69.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant