Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

feat: improve answer prompt by feeding facts #60

Merged
merged 5 commits into from
Jan 18, 2024
Merged

feat: improve answer prompt by feeding facts #60

merged 5 commits into from
Jan 18, 2024

Conversation

Jaszkowic
Copy link
Contributor

🫠

@render Render
Copy link

render bot commented Jan 18, 2024

Your Render PR Server URL is https://ki-anfragen-api-pr-60.onrender.com.

Follow its progress at https://dashboard.render.com/web/srv-cmkhegg21fec73e33h00.

@Jaszkowic
Copy link
Contributor Author

I also optimized the prompt so that the likelyhood of answering with "Abschnitte blabla" is decreased significantly.

@Jaszkowic
Copy link
Contributor Author

for every mentioned person in the facts list, i will embed their wikipedia article as well

@Jaszkowic
Copy link
Contributor Author

I tested this, including the embedding Wikipedia article locally. All questions in the facts list are answered correctly.

@Jaszkowic Jaszkowic marked this pull request as ready for review January 18, 2024 14:19
@Jaszkowic Jaszkowic requested a review from ff6347 as a code owner January 18, 2024 14:19
@Jaszkowic Jaszkowic requested a review from Esshahn January 18, 2024 14:19
@Jaszkowic
Copy link
Contributor Author

@ff6347 @Esshahn List of facts can be extended when needed.

@ff6347
Copy link
Collaborator

ff6347 commented Jan 18, 2024

🫠 indeed

Esshahn
Esshahn requested changes Jan 18, 2024
View reviewed changes
Copy link
Member

@Esshahn Esshahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Die Senatorin für Justiz und Verbraucherschutz ist Felor Badenberg (parteilos)."
->
"Die Senatorin für Justiz und Verbraucherschutz ist Dr. Felor Badenberg (parteilos).",

@Jaszkowic Jaszkowic requested a review from Esshahn January 18, 2024 15:10
Esshahn
Esshahn approved these changes Jan 18, 2024
View reviewed changes
Copy link
Member

@Esshahn Esshahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@Jaszkowic Jaszkowic merged commit 048c6a6 into main Jan 18, 2024
4 checks passed
@Jaszkowic Jaszkowic deleted the feat/improve-answer-prompt branch January 18, 2024 15:16
tsboter pushed a commit that referenced this pull request Jan 18, 2024
@semantic-release-bot
chore(release): 1.19.0 [skip ci]
8a12b50 
# [1.19.0](v1.18.0...v1.19.0) (2024-01-18)

### Features

* improve answer prompt by feeding facts ([#60](#60)) ([048c6a6](048c6a6))
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@ff6347 ff6347 ff6347 approved these changes

@Esshahn Esshahn Esshahn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jaszkowic @ff6347 @Esshahn