diff --git a/lib/gemdiff/bundle_inspector.rb b/lib/gemdiff/bundle_inspector.rb index 2a39503..beabfd8 100644 --- a/lib/gemdiff/bundle_inspector.rb +++ b/lib/gemdiff/bundle_inspector.rb @@ -8,8 +8,7 @@ def list @list ||= outdated .split("\n") - .map { |line| new_outdated_gem(line) } - .compact + .filter_map { |line| new_outdated_gem(line) } end def outdated diff --git a/lib/gemdiff/outdated_gem.rb b/lib/gemdiff/outdated_gem.rb index b329294..7af125d 100644 --- a/lib/gemdiff/outdated_gem.rb +++ b/lib/gemdiff/outdated_gem.rb @@ -105,7 +105,7 @@ def find_name(name) def clean_url(url) uri = URI.parse(url) - uri.path.gsub! %r{/+}, "/" + uri.path.squeeze!("/") uri.to_s end diff --git a/lib/gemdiff/repo_finder.rb b/lib/gemdiff/repo_finder.rb index 72b3c59..c44454a 100644 --- a/lib/gemdiff/repo_finder.rb +++ b/lib/gemdiff/repo_finder.rb @@ -115,7 +115,7 @@ def gemspec_homepage(gem_name) yaml = gemspec(gem_name) return if yaml.to_s.empty? spec = YAML.safe_load(yaml, permitted_classes: PERMITTED_GEMSPEC_CLASSES) - return clean_url(spec.homepage) if spec.homepage =~ GITHUB_REPO_REGEX + return clean_url(spec.homepage) if GITHUB_REPO_REGEX.match?(spec.homepage) match = spec.description.to_s.match(GITHUB_REPO_REGEX) match && clean_url(match[0]) end