Updated attribute regex to enable use of period and colon characters

Author: stephenoldham

src/Compiler.php

@@ -81,9 +81,9 @@ protected static function shortcodeRegex(string $tag): string
     public static function resolveAttributes(string $attributesText): ?array
     {
         $attributesText = preg_replace("/[\x{00a0}\x{200b}]+/u", ' ', $attributesText);
-
+        
         $attributes = collect([]);
-
+        
         if (preg_match_all(static::attributeRegex(), $attributesText, $matches, PREG_SET_ORDER)) {
             foreach ($matches as $match) {
                 if (! empty($match[1])) {
@@ -100,13 +100,13 @@ public static function resolveAttributes(string $attributesText): ?array
                     $attributes[] = stripcslashes($match[9]);
                 }
             }
-
+            
             // Reject any unclosed HTML elements.
             $filteredAttributes = $attributes->filter(function ($attribute) {
                 if (strpos($attribute, '<') === false) {
                     return true;
                 }
-
+                
                 return preg_match('/^[^<]*+(?:<[^>]*+>[^<]*+)*+$/', $attribute);
             });
 
@@ -127,6 +127,6 @@ public static function resolveAttributes(string $attributesText): ?array
      */
     protected static function attributeRegex(): string
     {
-        return '/([\w-]+)\s*=\s*"([^"]*)"(?:\s|$)|([\w-]+)\s*=\s*\'([^\']*)\'(?:\s|$)|([\w-]+)\s*=\s*([^\s\'"]+)(?:\s|$)|"([^"]*)"(?:\s|$)|\'([^\']*)\'(?:\s|$)|(\S+)(?:\s|$)/';
+        return '/([\w.:-]+)\s*=\s*"([^"]*)"(?:\s|$)|([\w.:-]+)\s*=\s*\'([^\']*)\'(?:\s|$)|([\w.:-]+)\s*=\s*([^\s\'"]+)(?:\s|$)|"([^"]*)"(?:\s|$)|\'([^\']*)\'(?:\s|$)|(\S+)(?:\s|$)/';
     }
 }

src/Shortcode.php

@@ -31,6 +31,13 @@ abstract class Shortcode
      */
     protected $tag;
 
+    /**
+     * Optional closing tag to match in content.
+     *
+     * @var string
+     */
+    protected $closingTag;
+
     /**
      * The shortcode's body content.
      *
@@ -235,7 +242,7 @@ public function getCasts()
     }
 
     /**
-     * Get an attribute from the model.
+     * Get an attribute from the class.
      *
      * @param  string  $key
      * @return mixed

tests/ShortcodeTest.php

@@ -233,7 +233,9 @@ public function testShortcodeAttributesCasting(): void
     {
         collect([
             '[cast_boolean test-boolean]' => 'true',
+            // '[cast_boolean test-boolean="true"]' => 'true',
             '[cast_boolean test-boolean="1"]' => 'true',
+            // '[cast_boolean test-boolean="false"]' => 'false',
             '[cast_boolean test-boolean="0"]' => 'false',
             '[cast_boolean /]' => 'false',
             '[cast_date test-date="2023-06-29"]' => (string) Date::parse('2023-06-29')->timestamp,