Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feature: add spec to specify EventListener service port 🚪 #1270

Closed
waveywaves opened this issue Nov 24, 2021 · 2 comments · Fixed by #1272
Closed

feature: add spec to specify EventListener service port 🚪 #1270

waveywaves opened this issue Nov 24, 2021 · 2 comments · Fixed by #1272
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@waveywaves
Copy link
Member

Feature request

Update EventListener port to something other than port 8080. The EventListener Service has port config similar to the following. This feature request entails allowing the user to change the "port" to something other than 8080 via a spec change.

ports:
    - protocol: TCP
      port: 8080 <----- this
      targetPort: ??

Currently, ServiceType is something the user can provide to change the type of the service from the default "ClusterIP" to the alternatives (LoadBalancer, NodePort). Similarly, we should also be able to change the port. It can be named ServicePort initially without involving any breaking changes.

Use case

User wants to expose their Webhooks to a port apart from 8080, cuz they need spice 🌶️ in lyf.

@waveywaves waveywaves added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 24, 2021
@waveywaves
Copy link
Member Author

/assign waveywaves

@dibyom
Copy link
Member

dibyom commented Nov 24, 2021

cuz they need spice 🌶️ in lyf.

🤣

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants