-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feat(component-library): [TELFE-958] SocketedText #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: https://telicent.atlassian.net/browse/TELFE-958
Goal
Create component for text + icon
Work Completed
Testing Method
Not able to test - as can't link locally - but running out of time. So I'll just publish and test.
Once I'm happy with it, I'll write the unit tests.
Code Review Tips
Engineering Notes
Out-of-scope
🕵️ Review Guidance
General guidance
For PR REVIEWER:
[pr-owner-resolve]
: Jim is also editing this file"pr-author-resolve
PR author can resolve after readingpr-author-delete
(rare) delete after reading to avoid confusionFor PR AUTHOR: