Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(component-library): [TELFE-958] SocketedText #190

Merged
merged 13 commits into from
Feb 12, 2025

Conversation

ACoolmanTelicent
Copy link
Contributor

@ACoolmanTelicent ACoolmanTelicent commented Feb 11, 2025

Ticket: https://telicent.atlassian.net/browse/TELFE-958

Goal

Create component for text + icon

Work Completed

Testing Method

Not able to test - as can't link locally - but running out of time. So I'll just publish and test.

Once I'm happy with it, I'll write the unit tests.

Code Review Tips

Engineering Notes

Out-of-scope


🕵️ Review Guidance

General guidance

  • Generally, approve a PR if it makes the system better, even if it's not perfect. — Google: The Standard of Code Review
  • The aim of both PR AUTHOR and PR REVIEWER is to get the code merged
  • Aim for consensus, defined as everyone can live with the outcome
  • PR with changes requires 2 approvals
  • PR with no changes requires 1 approvals

For PR REVIEWER:

  1. Read the ticket & description
  2. Review the code
  3. Request any changes that are essential.
  4. For non-essential comments:
    • Use prefixes, e.g. "nit: change to Pascal case"
      • nit: small, non-essential change
      • obs: just an observation, doesn't affect the PR
      • idea: a suggestion to think about
      • q: questions
    • Use modifiers, e.g. "obs[pr-owner-resolve]: Jim is also editing this file"
      • pr-author-resolve PR author can resolve after reading
      • pr-author-delete (rare) delete after reading to avoid confusion
  5. try to add at least a helpful comment per ~500 lines; less if the PR is already busy

For PR AUTHOR:

  1. Aim for enough detail in PR description for things to go smoothly
  2. After requested changes, re-request a review (so the PR shows up in reviews-requested:@me)

@ACoolmanTelicent ACoolmanTelicent merged commit 24b67c4 into main Feb 12, 2025
3 checks passed
@ACoolmanTelicent ACoolmanTelicent deleted the TELFE-958/SocketedText branch February 12, 2025 18:19
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants