From 7d9aca5771143f37be40a043ddc3f42a10e3fcc0 Mon Sep 17 00:00:00 2001
From: Chad Retz <chad@temporal.io>
Date: Wed, 14 Feb 2024 08:20:38 -0600
Subject: [PATCH] More env tests

---
 temporalcli/commands.env_test.go | 52 ++++++++++++++++++++++++++------
 1 file changed, 42 insertions(+), 10 deletions(-)

diff --git a/temporalcli/commands.env_test.go b/temporalcli/commands.env_test.go
index 0dc6eb94..24721eec 100644
--- a/temporalcli/commands.env_test.go
+++ b/temporalcli/commands.env_test.go
@@ -7,20 +7,14 @@ import (
 	"gopkg.in/yaml.v3"
 )
 
-// TODO(cretz): To test:
-// * Env var actually sets CLI arg
-// * Get single and all for env
-// * Delete single and all for env
-// * List envs
-
 func TestEnv_Simple(t *testing.T) {
 	h := NewCommandHarness(t)
 	defer h.Close()
 
 	// Non-existent file, no env found for get
 	h.Options.EnvConfigFile = "does-not-exist"
-	res := h.Execute("env", "get", "myenv")
-	h.ErrorContains(res.Err, `env "myenv" not found`)
+	res := h.Execute("env", "get", "myenv1")
+	h.ErrorContains(res.Err, `env "myenv1" not found`)
 
 	// Temp file for env
 	tmpFile, err := os.CreateTemp("", "")
@@ -29,12 +23,50 @@ func TestEnv_Simple(t *testing.T) {
 	defer os.Remove(h.Options.EnvConfigFile)
 
 	// Store a key
-	res = h.Execute("env", "set", "myenv.foo", "bar")
+	res = h.Execute("env", "set", "myenv1.foo", "bar")
 	h.NoError(res.Err)
 	// Confirm file is YAML with expected values
 	b, err := os.ReadFile(h.Options.EnvConfigFile)
 	h.NoError(err)
 	var yamlVals map[string]map[string]map[string]string
 	h.NoError(yaml.Unmarshal(b, &yamlVals))
-	h.Equal("bar", yamlVals["env"]["myenv"]["foo"])
+	h.Equal("bar", yamlVals["env"]["myenv1"]["foo"])
+
+	// Store another key and another env
+	res = h.Execute("env", "set", "myenv1.baz", "qux")
+	h.NoError(res.Err)
+	res = h.Execute("env", "set", "myenv2.foo", "baz")
+	h.NoError(res.Err)
+
+	// Get single prop
+	res = h.Execute("env", "get", "myenv1.baz")
+	h.NoError(res.Err)
+	h.ContainsOnSameLine(res.Stdout.String(), "baz", "qux")
+	h.NotContains(res.Stdout.String(), "foo")
+
+	// Get all props for env
+	res = h.Execute("env", "get", "myenv1")
+	h.NoError(res.Err)
+	h.ContainsOnSameLine(res.Stdout.String(), "foo", "bar")
+	h.ContainsOnSameLine(res.Stdout.String(), "baz", "qux")
+
+	// List envs
+	res = h.Execute("env", "list")
+	h.NoError(res.Err)
+	h.Contains(res.Stdout.String(), "myenv1")
+	h.Contains(res.Stdout.String(), "myenv2")
+
+	// Delete single env value
+	res = h.Execute("env", "delete", "myenv1.foo")
+	h.NoError(res.Err)
+	res = h.Execute("env", "get", "myenv1")
+	h.NoError(res.Err)
+	h.NotContains(res.Stdout.String(), "foo")
+
+	// Delete entire env
+	res = h.Execute("env", "delete", "myenv2")
+	h.NoError(res.Err)
+	res = h.Execute("env", "list")
+	h.NoError(res.Err)
+	h.NotContains(res.Stdout.String(), "myenv2")
 }