Skip to content

Commit 79e448a

Browse files
committed
Get rid of fix-wheel hacks
1 parent 532388d commit 79e448a

File tree

6 files changed

+5
-109
lines changed

6 files changed

+5
-109
lines changed

.github/workflows/build-binaries.yml

+3-4
Original file line numberDiff line numberDiff line change
@@ -44,19 +44,18 @@ jobs:
4444
with:
4545
workspaces: temporalio/bridge -> target
4646
- uses: astral-sh/setup-uv@v5
47-
- run: python -m pip install --upgrade wheel poethepoet
47+
- run: python -m pip install poethepoet
4848
- run: uv sync --all-extras
4949
- run: uv build
5050

5151
# Add the source dist only for Linux x64 for now
5252
- if: ${{ matrix.package-suffix == 'linux-amd64' }}
5353
run: uv build --sdist
5454

55-
# Build and fix the wheel
55+
# Build the wheel
5656
- run: uv run cibuildwheel --output-dir dist
57-
- run: poe fix-wheel
5857

59-
# Simple test
58+
# Run a test
6059
- run: uv run pytest -k test_activity_hello
6160

6261
# Upload dist

.github/workflows/ci.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ jobs:
4747
version: "23.x"
4848
repo-token: ${{ secrets.GITHUB_TOKEN }}
4949
- uses: astral-sh/setup-uv@v5
50-
- run: python -m pip install --upgrade wheel poethepoet
50+
- run: python -m pip install poethepoet
5151
- run: uv sync --all-extras
5252
- run: poe bridge-lint
5353
if: ${{ matrix.clippyLinter }}

README.md

+1-6
Original file line numberDiff line numberDiff line change
@@ -1424,13 +1424,8 @@ environment](#local-sdk-development-environment) for the quicker approach to loc
14241424
uv build
14251425
```
14261426

1427-
The compiled wheel doesn't have the exact right tags yet for use, so run this script to fix it:
14281427

1429-
```bash
1430-
poe fix-wheel
1431-
```
1432-
1433-
The `whl` wheel file in `dist/` is now ready to use.
1428+
The `.whl` wheel file in `dist/` is now ready to use.
14341429

14351430
#### Use
14361431

pyproject.toml

-2
Original file line numberDiff line numberDiff line change
@@ -47,15 +47,13 @@ dev = [
4747
"ruff>=0.5.0,<0.6",
4848
"toml>=0.10.2,<0.11",
4949
"twine>=4.0.1,<5",
50-
"wheel>=0.42.0,<0.43",
5150
"ruff>=0.5.0,<0.6",
5251
"maturin>=1.8.2",
5352
]
5453

5554
[tool.poe.tasks]
5655
build-develop = "uv run maturin develop --uv"
5756
build-develop-with-release = { cmd = "uv run maturin develop --release --uv" }
58-
fix-wheel = "uv run python scripts/fix_wheel.py"
5957
format = [{cmd = "uv run ruff check --select I --fix"}, {cmd = "uv run ruff format"}, ]
6058
gen-docs = "uv run python scripts/gen_docs.py"
6159
gen-protos = "uv run python scripts/gen_protos.py"

scripts/fix_wheel.py

-85
This file was deleted.

uv.lock

-11
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)