From d5482f1d1c90169da0fde8568a2ae41215550096 Mon Sep 17 00:00:00 2001
From: Rodrigo Zhou <2068124+rodrigozhou@users.noreply.github.com>
Date: Wed, 2 Oct 2024 18:49:38 -0500
Subject: [PATCH] Remove track_total_hits from Scroll API (#6592)

## What changed?
<!-- Describe what has changed in this PR -->
Remove track_total_hits from Scroll API

## Why?
<!-- Tell your future self why have you made these changes -->
`track_total_hits` cannot be disable in Scroll API.

Issue: https://github.com/temporalio/temporal/issues/6566

## How did you test it?
<!-- How have you verified this change? Tested locally? Added a unit
test? Checked in staging env? -->

## Potential risks
<!-- Assuming the worst case, what can be broken when deploying this
change to production? -->

## Documentation
<!-- Have you made sure this change doesn't falsify anything currently
stated in `docs/`? If significant
new behavior is added, have you described that in `docs/`? -->

## Is hotfix candidate?
<!-- Is this PR a hotfix candidate or does it require a notification to
be sent to the broader community? (Yes/No) -->
---
 .../visibility/store/elasticsearch/client/client_v7.go           | 1 -
 1 file changed, 1 deletion(-)

diff --git a/common/persistence/visibility/store/elasticsearch/client/client_v7.go b/common/persistence/visibility/store/elasticsearch/client/client_v7.go
index e18a6d6411f..be3e642ceed 100644
--- a/common/persistence/visibility/store/elasticsearch/client/client_v7.go
+++ b/common/persistence/visibility/store/elasticsearch/client/client_v7.go
@@ -193,7 +193,6 @@ func (c *clientImpl) OpenScroll(
 		Index(p.Index).
 		Query(p.Query).
 		SortBy(p.Sorter...).
-		TrackTotalHits(false).
 		KeepAlive(keepAliveInterval)
 	if p.PageSize != 0 {
 		scrollService.Size(p.PageSize)