Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove unused methods in ClientBean #3532

Open
yux0 opened this issue Oct 24, 2022 · 3 comments
Open

Remove unused methods in ClientBean #3532

yux0 opened this issue Oct 24, 2022 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@yux0
Copy link
Contributor

yux0 commented Oct 24, 2022

Is your feature request related to a problem? Please describe.

  1. Remove unused methods in ClientBean
  2. Add new method GetAdminClient to align with Frontend Client

Describe the solution you'd like

  1. Remove unused methods in ClientBean
  2. Add new method GetAdminClient to align with Frontend Client

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@yux0 yux0 added the enhancement New feature or request label Oct 24, 2022
@yux0 yux0 self-assigned this Oct 24, 2022
@alexshtin
Copy link
Member

I would remove entire ClientBean and replace it with proper fx injections.

@sync-by-unito sync-by-unito bot closed this as completed Mar 3, 2023
@yiminc yiminc reopened this Mar 3, 2023
@yiminc
Copy link
Member

yiminc commented Oct 22, 2023

#5000

@dnr
Copy link
Member

dnr commented Oct 23, 2023

#5000 is for the persistence client bean only, not the rpc one that this issue is about

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants