Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Investigate error handling in auction creation hooks #869

Open
lumtis opened this issue Jun 14, 2022 · 0 comments
Open

Investigate error handling in auction creation hooks #869

lumtis opened this issue Jun 14, 2022 · 0 comments
Labels
campaign Related to campaign module

Comments

@lumtis
Copy link
Contributor

lumtis commented Jun 14, 2022

Depends on #841

AfterFixedPriceAuctionCreated and AfterBatchAuctionCreated use the method EmitCampaignAuctionCreated that can fail with an error (should never be the case and therefore might be considered as a critical error)

This task is about investigating how to handle the error since the hook doesn't return an error

Potentially add logging for the error
@lumtis lumtis added the campaign Related to campaign module label Jun 14, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
campaign Related to campaign module
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lumtis