-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Implementation proposal for audio resample #1392
Comments
@AlexFuster The resample was implemented wit speex in the current repo. If an alternative implementation brings additional advantage (like matching resampy/etc) then we certainly welcome PRs. |
So, do I replace the resample function in |
@AlexFuster You can replace the resample function in audio_ops.py and replace C++ kernel in https://github.com/tensorflow/io/blob/master/tensorflow_io/core/kernels/audio_kernels.cc#L220-L299 |
But our implementation is fully in python (using Tensorflow operations). I'll just replace the resample function |
@AlexFuster Sure. Please go ahead and submit the PR. We can decide in the PR if the original C++ kernel can be removed or we want to keep them for now. |
Sorry, I forgot to add an import to the first one |
At Voicemod, we have made a tensorflow version of the audio resampling function from torchaudio https://pytorch.org/audio/stable/transforms.html?highlight=resample#torchaudio.transforms.Resample.
I think It would be a good alternative/complement for the current implementation of audio resampling of this repo https://www.tensorflow.org/io/api_docs/python/tfio/audio/resample for 4 reasons.
Tell me if you are interested
The text was updated successfully, but these errors were encountered: