Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Performance issue in /data.py (by P3) #28

Open
DLPerf opened this issue Aug 29, 2021 · 1 comment
Open

Performance issue in /data.py (by P3) #28

DLPerf opened this issue Aug 29, 2021 · 1 comment

Comments

@DLPerf
Copy link

DLPerf commented Aug 29, 2021

Hello! I've found a performance issue in /data.py: ds.batch(batch_size)(here) should be called before ds.map(_map_fn, num_parallel_calls=4)(here), which could make your program more efficient.

Here is the tensorflow document to support it.

Besides, you need to check the function _map_fn called in ds.map(_map_fn, num_parallel_calls=4) whether to be affected or not to make the changed code work properly. For example, if _map_fn needs data with shape (x, y, z) as its input before fix, it would require data with shape (batch_size, x, y, z) after fix.

Looking forward to your reply. Btw, I am very glad to create a PR to fix it if you are too busy.

@DLPerf
Copy link
Author

DLPerf commented Nov 4, 2021

Hello, I'm looking forward to your reply~

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant