This repository has been archived by the owner on May 29, 2024. It is now read-only.
Fix sighting context post-processing #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobim
reviewed
Apr 26, 2021
0snap
force-pushed
the
topic/fix-sighting-context-mangling
branch
from
f8096ae to
6d72c38
Compare
0snap
force-pushed
the
topic/fix-sighting-context-mangling
branch
from
6d72c38 to
b0df216
Compare
dominiklohmann
approved these changes
Apr 26, 2021
There was a problem hiding this comment.
This took me a while to get running, but it seems to work. Not sure if I tested everything, but I managed to go use the previously defunct options.
There's one spelling mistake in the changelog entry, and I'd like to see a new story for creating an integration test for this feature so it's not as complicated to test. Afterwards feel free to merge.
0snap
force-pushed
the
topic/fix-sighting-context-mangling
branch
from
b0df216 to
5e86c7c
Compare
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📔 Description
Fix a bug with sighting context post-processing (both custom sinks and context transformation).
📝 Checklist
🎯 Review Instructions
Enable both live- and retro-matching and test interactively by passing sighting context into fever alertify (use example config).