This repository has been archived by the owner on May 29, 2024. It is now read-only.
Fix format of line protocol metrics syntax #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0snap
reviewed
Jun 28, 2021
Done! |
0snap
suggested changes
Jun 28, 2021
Co-authored-by: Felix <flx.ortmann@gmail.com>
0snap
approved these changes
Jun 28, 2021
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📔 Description
The current implementation of the metrics value serialization includes spaces into the fields of the measurements, which is not valid according to the spec and will cause the measurement to be rejected. This PR changes this behaviour to ensure all fields are separated by commas.
📝 Checklist
🎯 Review Instructions
Compare code and output to line protocol specification.