Skip to content
This repository has been archived by the owner on May 29, 2024. It is now read-only.

Start measurement of query time metric w/ actual query #145

Merged
merged 2 commits into from
Jun 30, 2021

Conversation

0snap
Copy link
Contributor

@0snap 0snap commented Jun 30, 2021

📔 Description

Start the measurement of the query time metric together with the actual indicator. This way, we don't skew the metric with indicators that cannot be processed due to user settings for max-background tasks.

📝 Checklist

  • All user-facing changes have changelog entries.
  • The changes are reflected on docs.tenzir.com/threatbus, if necessary.
  • The PR description contains instructions for the reviewer, if necessary.

🎯 Review Instructions

n/t

@0snap 0snap marked this pull request as ready for review June 30, 2021 12:47
Copy link
Member

@lava lava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I kinda assumed it was intentionally outside of the async-block while doing the initial review, so we can see when threatbus is backlogged by its open tasks.

But, either way is fine with me.

@dominiklohmann dominiklohmann added the bug Incorrect behavior label Jun 30, 2021
@0snap
Copy link
Contributor Author

0snap commented Jun 30, 2021

We now have a dedicated metric to track said backlog, so this one can go into the async block 👍

@0snap 0snap added maintenance Tasks for keeping up the infrastructure and removed bug Incorrect behavior labels Jun 30, 2021
@0snap 0snap merged commit 7116786 into master Jun 30, 2021
@0snap 0snap deleted the topic/query-time-metric branch June 30, 2021 12:57
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
maintenance Tasks for keeping up the infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants