This repository has been archived by the owner on May 29, 2024. It is now read-only.
Fix RabbitMQ user-defined queue parameters #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0snap
changed the title
mavam
approved these changes
Nov 30, 2020
plugins/backbones/threatbus_rabbitmq/threatbus_rabbitmq/rabbitmq_consumer.py
Show resolved
Hide resolved
0snap
force-pushed
the
story/ch2653/fix-rabbitmq-queue-params
branch
from
3d2ba28 to
f29c8c4
Compare
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📔 Description
The rewrite in #61 introduced this bug. User-defined queue parameters were not passed to the RabbitMQ host.
This PR shall be released "out-of-band". Note: Our release workflow will trigger once we publish a new release. It will try to re-upload to PyPI and it will fail, because PyPI does not allow the re-use of existing versions but most versions haven't changed. So releasing without bumping all version numbers will color our CI red. It won't affect the correctness of the release, though.
📝 Checklist
🎯 Review Instructions
File-by-file.