Skip to content
This repository has been archived by the owner on May 29, 2024. It is now read-only.

Remove unflatten from pyvast-threatbus #92

Merged
merged 4 commits into from
Jan 19, 2021
Merged

Conversation

0snap
Copy link
Contributor

@0snap 0snap commented Jan 12, 2021

📔 Description

pyvast-threatbus used to have an optional feature to unflatten JSON that it receives from vast export. This is no longer needed as of tenzir/tenzir#1257. This PR removes the unflatten dependency and all usages in the code.

📝 Checklist

  • All user-facing changes have changelog entries.
  • The changes are reflected on docs.tenzir.com/threatbus, if necessary.
  • The PR description contains instructions for the reviewer, if necessary.

🎯 Review Instructions

Commit-by-commit.

@0snap 0snap added the maintenance Tasks for keeping up the infrastructure label Jan 12, 2021
@0snap 0snap marked this pull request as ready for review January 19, 2021 11:52
@0snap 0snap force-pushed the story/ch2929/remove-unflatten branch from a80824b to 008960e Compare January 19, 2021 11:52
@0snap 0snap requested a review from mavam January 19, 2021 11:52
@0snap
Copy link
Contributor Author

0snap commented Jan 19, 2021

FYI @satta

@satta
Copy link
Contributor

satta commented Jan 19, 2021

FYI @satta

Got it!

Copy link
Member

@mavam mavam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Always refreshing to simplify things.

I didn't test this but looked closely at the baseline change.

Co-authored-by: Matthias Vallentin <matthias@tenzir.com>
@0snap 0snap merged commit 41cd3ec into master Jan 19, 2021
@0snap 0snap deleted the story/ch2929/remove-unflatten branch January 19, 2021 13:30
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
maintenance Tasks for keeping up the infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants