-
-
Notifications
You must be signed in to change notification settings - Fork 16
Conversation
This pull request introduces 2 alerts when merging 5ef2c14 into 671a0ea - view on LGTM.com new alerts:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ran this branch locally, and tested it. RabbitMQ backbone / ZMQ sender / receiver and was able to send messages across. I also tried to send some gibberish and that failed as expected.
I went through the code commit-by-commit. I'm not intimitely familiar with Threatbus nor Python, but I did not see anything out of the ordinary. I saw some points where I would possibly break some elements out to functions (like the double big try catch block in rabbitmq_publisher), but at the same time, breaking it out to a different file would not necessarily make it more clear.
If anyone wants to weigh in as well, feel free. But from my pov this is good to go :)
📔 Description
in-memory
backbone pluginZMQ-App
pluginpyvast-threatbus
are disabled to make the CI happy. They will be migrated in separate PRs📝 Checklist
🎯 Review Instructions
This PR can already be reviewed. Documentation will follow in the next iteration.
tests/utils
to test all functionalityWalkthrough:
Then you can use the
tests/utils/zmq_sender.py
andtests/utils/zmq_receiver.py
to mimick small "apps". They connect to the ZMQ plugin and send messages back and forth. This should work independent of the backbone (in-mem or rabbit). Try both.