Skip to content

feat: Add example for connecting via Session Manager without Internet access #336

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 8 commits into from
Aug 30, 2023
Merged

feat: Add example for connecting via Session Manager without Internet access #336

merged 8 commits into from
Aug 30, 2023

Conversation

luigidifraiawork
Copy link
Contributor

Description

Add an example demonstrating how an EC2 instance not connected to the Internet can be accessed using Session Manager through VPC Endpoints.

Motivation and Context

I thought to provide the open-source community with a working example for the above-mentioned scenario.

Breaking Changes

None.

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@luigidifraiawork luigidifraiawork marked this pull request as ready for review June 8, 2023 05:07
@luigidifraiawork luigidifraiawork changed the title feat: Add example for connecting via Session Manager without Internet feat: Add example for connecting via Session Manager without Internet access Jun 9, 2023
@luigidifraiawork
Copy link
Contributor Author

@antonbabenko Is there anything I can help with in order to facilitate a review of this pull request, please? I am happy to keep rebasing it in the meantime.

@github-actions
Copy link

github-actions bot commented Aug 6, 2023

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

@github-actions github-actions bot added the stale label Aug 6, 2023
@luigidifraiawork
Copy link
Contributor Author

Not stale.

@github-actions github-actions bot removed the stale label Aug 11, 2023
bryantbiggs
bryantbiggs approved these changes Aug 30, 2023
View reviewed changes
Copy link
Member

@bryantbiggs bryantbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, thank you!

@bryantbiggs bryantbiggs merged commit 68edef8 into terraform-aws-modules:master Aug 30, 2023
antonbabenko pushed a commit that referenced this pull request Aug 30, 2023
@semantic-release-bot
chore(release): version 5.5.0 [skip ci]
6c13542 
## [5.5.0](v5.4.0...v5.5.0) (2023-08-30)

### Features

* Add example for connecting via Session Manager without Internet access ([#336](#336)) ([68edef8](68edef8))
@antonbabenko
Copy link
Member

This PR is included in version 5.5.0 🎉

@luigidifraiawork luigidifraiawork deleted the feat/session-manager-no-internet-access-example branch August 31, 2023 09:39
@luigidifraiawork
Copy link
Contributor Author

awesome, thank you!

You're welcome. Thank you for reviewing, approving and making this example part of the module.

@github-actions
Copy link

github-actions bot commented Oct 6, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 6, 2023
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers

@bryantbiggs bryantbiggs bryantbiggs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@luigidifraiawork @antonbabenko @bryantbiggs