feat: Added parameter to attach aws_eip

[tokarev-artem]

Description

Added parameter to create an attach aws_eip resource to ec2 instance

Motivation and Context

It allows to attach public static IP address which will not be changed after ec2 instance stop/start

Breaking Changes

How Has This Been Tested?

• [*] I have updated at least one of the examples/* to demonstrate and validate my change(s)
• [*] I have tested and validated these changes using one or more of the provided examples/* projects

• [*] I have executed pre-commit run -a on my pull request

[antonbabenko]

LGTM, minor comments.

@bryantbiggs WDYT?

[bryantbiggs]

looks good to me - although, I am curious why you are using an EIP on a standalone instance in 2024 😅

[tokarev-artem]

Hi @antonbabenko is there anything else required to add/change/edit?

[mikecook]

looks good to me - although, I am curious why you are using an EIP on a standalone instance in 2024 😅

@bryantbiggs @antonbabenko I'd like this feature for a bastion server for a reporting tool that doesn't need high availability.

[bryantbiggs]

I'd like this feature for a bastion server for a reporting tool that doesn't need high availability.

And SSM session manager doesn't work for that? (I've approved the PR from my end, more of a pet peeve of this behavior over more modern practices really)

[mikecook]

I'd like this feature for a bastion server for a reporting tool that doesn't need high availability.

And SSM session manager doesn't work for that? (I've approved the PR from my end, more of a pet peeve of this behavior over more modern practices really)

I understand. No way to use SSM in this case, to my knowledge. I'm limited by 3rd party configuration options. The reporting tool is 3rd party automation that uses ssh-key to pass through bastion via SSH tunnel. It doesn't do anything on the ec2 instance.

[mikecook]

@antonbabenko Heads up, this PR is approved but is blocked by your acceptance of your requested changes.

[github-actions]

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

[mikecook]

@antonbabenko Heads up, this PR is approved but is blocked by your acceptance of your requested changes.

@antonbabenko This is ready. A user has done the work. Please respond to your blocking review feedback that has been addressed. This was marked stale while awaiting your response. It is otherwise ready to merge.

CC: @bryantbiggs

[github-actions]

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

[mikecook]

@apparentlymart @shawnsavour @bryantbiggs Can anyone unblock this?

[bryantbiggs]

I cannot remove a review that requests changes - we'll need to wait for Anton to review and update

[antonbabenko]

This PR is included in version 5.7.0 🎉

[carnei-ro]

i'm facing this problem now:

Error: Value for unconfigurable attribute

  with module.ec2_instance.aws_eip.this,
  on .terraform/modules/ec2_instance/main.tf line 619, in resource "aws_eip" "this":
 619:   domain = var.eip_domain

Can't configure a value for "domain": its value will be decided automatically

[bryantbiggs]

ugh, the EIP resource brought in a v5.0 argument hashicorp/terraform-provider-aws#31567

Looks like we'll have to take a breaking change

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.