Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: Add missing Name tag to service security group #177

Merged
merged 2 commits into from
Mar 4, 2024

Conversation

lays147
Copy link
Contributor

@lays147 lays147 commented Mar 4, 2024

Description

The Security Group in ECS Service is missing the "Name" tag.

Motivation and Context

Breaking Changes

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

lays147 and others added 2 commits March 4, 2024 14:17
Signed-off-by: Lays Rodrigues <laysrodriguessilva@gmail.com>
Copy link
Member

@bryantbiggs bryantbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@bryantbiggs bryantbiggs changed the title fix: Add missing Name tag in service sg fix: Add missing Name tag to service security group Mar 4, 2024
@bryantbiggs bryantbiggs merged commit b3600de into terraform-aws-modules:master Mar 4, 2024
12 checks passed
antonbabenko pushed a commit that referenced this pull request Mar 4, 2024
### [5.9.2](v5.9.1...v5.9.2) (2024-03-04)

### Bug Fixes

* Add missing `Name` tag to service security group ([#177](#177)) ([b3600de](b3600de))
@antonbabenko
Copy link
Member

This PR is included in version 5.9.2 🎉

Copy link

github-actions bot commented Apr 6, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 6, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants