Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: Allow task exec IAM policy to have an IAM path #243

Merged
merged 7 commits into from
Nov 29, 2024

Conversation

rmolson
Copy link
Contributor

@rmolson rmolson commented Nov 29, 2024

Description

This PR adds the ability to have a path in the task exec policy in modules/service/main.tf

Motivation and Context

On some of the accounts I work on, I can't write a role or policy to the root of IAM, I have to put each policy in a different IAM path based on different factors. While most of the policies support this, there is one that is missing the path argument.

Also noted in #199

Breaking Changes

No breaking changes

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@rmolson
Copy link
Contributor Author

rmolson commented Nov 29, 2024

$terraform version
Terraform v1.10.0
on linux_amd64
+ provider registry.terraform.io/hashicorp/aws v5.78.0
$pre-commit run -a
Terraform fmt............................................................Passed
Terraform wrapper with for_each in module................................Passed
Terraform docs...........................................................Passed
Terraform validate with tflint...........................................Passed
Terraform validate.......................................................Passed
check for merge conflicts................................................Passed
fix end of files.........................................................Passed
trim trailing whitespace.................................................Passed

Trying to figure what the difference is in the pipeline. for the document updates, I think the pipeline is using 1.9, should lower my terraform version locally to 1.9.x?

Updated, updated my local terraform-docs

@rmolson
Copy link
Contributor Author

rmolson commented Nov 29, 2024

This now passes on actions on my fork, please approve the workflow again.

@bryantbiggs bryantbiggs changed the title feat: Allow task_exec IAM policy to have an IAM path feat: Allow task exec IAM policy to have an IAM path Nov 29, 2024
@bryantbiggs bryantbiggs merged commit c9dc889 into terraform-aws-modules:master Nov 29, 2024
12 checks passed
antonbabenko pushed a commit that referenced this pull request Nov 29, 2024
## [5.12.0](v5.11.4...v5.12.0) (2024-11-29)

### Features

* Allow task exec IAM policy to have an IAM path ([#243](#243)) ([c9dc889](c9dc889))

### Bug Fixes

* Update CI workflow versions to latest ([#236](#236)) ([fd0f0ec](fd0f0ec))
@antonbabenko
Copy link
Member

This PR is included in version 5.12.0 🎉

Copy link

github-actions bot commented Jan 2, 2025

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 2, 2025
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants