-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feat: Tags passed into worker groups override tags from var.tags
for Autoscaling groups
#1092
Conversation
…oups or worker_groups_launch_template so that propagate_at_launch can be tweeked for a particular key.
I've just merged latest master too |
var.tags
for Autoscaling groups
Thanks @huddy for your contribution. I'll make a new release as soon as fargate PR is merged. |
Thanks for the very quick turnaround @barryib and once again thanks to you and other maintainers for awesome work. |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
PR o'clock
Description
This PR brings an enhancement that allows tags that are passed into
var.worker_groups_launch_template
orvar.worker_groups
to override tags passed in viavar.tags
for ASGs only.This relates to #1091
The main use case for this is where a tag is required everywhere apart from worker nodes. In this case we can pass the tag in via
var.tags
, but then pass it in with the worker template and setpropagate_at_launch
tofalse
.In order to ensure that the override only happens where it needs to I had to move the asg_tags for expression from
locals.tf
to be in the context of each worker template.This way we don't incorrectly override tags where we haven't actually overwritten them.
I wasn't sure if you would class this as an improvement or feature, but I went with improvement, happy to change it to a "feature".
Checklist