Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: Ability to specify cluster update timeout #1588

Merged
merged 1 commit into from
Sep 17, 2021
Merged

feat: Ability to specify cluster update timeout #1588

merged 1 commit into from
Sep 17, 2021

Conversation

mkilchhofer
Copy link
Contributor

@mkilchhofer mkilchhofer commented Sep 16, 2021

PR o'clock

Description

Our intent is to update our exising EKS cluster with cluster_encryption_config as it was introduced here:

Unfortunately updating the cluster with cluster_encryption_config consumes more than 1h (at least in euc1).

As a default I used what's default in the resource aws_eks_cluster: https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/eks_cluster#timeouts

Checklist

Copy link
Contributor

@daroga0002 daroga0002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@antonbabenko antonbabenko merged commit 46f16d6 into terraform-aws-modules:master Sep 17, 2021
@antonbabenko
Copy link
Member

Thanks @mkilchhofer for this PR!

v17.20.0 has been just released.

@mkilchhofer mkilchhofer deleted the feature/cluster_update_timeout branch September 17, 2021 15:06
lisfo4ka pushed a commit to lisfo4ka/terraform-aws-eks that referenced this pull request Oct 12, 2021
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 12, 2022
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants