Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: Fix destruction failure when talking to EKS endpoint on private network #815

Merged

Conversation

b2cbre
Copy link
Contributor

@b2cbre b2cbre commented Mar 23, 2020

PR o'clock

Description

In #812 we have a situation where when one attempts to terraform destroy and cluster_endpoint_public_access is false then an error will be encountered:
Error: Get https://SNIP.eks.amazonaws.com/api/v1/namespaces/kube-system/configmaps/aws-auth: dial tcp IP:443: i/o timeout (IP:443 is the IP of the endpoint).

This change has been tested with cluster_endpoint_public_access as true and as false. I tested it by running tf apply && tf destroy in each case, verifying that it completed.

Resolves #812

Checklist

@b2cbre
Copy link
Contributor Author

b2cbre commented Mar 23, 2020

README.md has been updated after any changes to variables and outputs.
Is there anything to update in the README?

@barryib barryib changed the title fix: destruction fails when talking to API on private network. fix: Fix destruction failure when talking to EKS endpoint on private network Mar 24, 2020
@barryib barryib merged commit 49b0667 into terraform-aws-modules:master Mar 24, 2020
@b2cbre b2cbre deleted the configmapDependOnPrivRules branch June 30, 2020 20:47
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 17, 2022
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kubernetes_config_map causing terraform destroy to fail?
2 participants