fix: More compatibility fixes for Terraform v0.13 and aws v3

[dpiddockcmp]

PR o'clock

Description

Terraform v0.13 and aws v3 support time!

• The update to the vpc module was, strictly speaking, unnecessary but it adds the terraform block with supported versions.
• Update for iam module was very necessary to support new versions
• Workaround for "Provider produced inconsistent final plan" when creating ASGs at the same time as the cluster. See [aws_autoscaling_group] Provider produced inconsistent final plan (for tags) hashicorp/terraform-provider-aws#14085 for full details.

When upgrading an existing TF 0.12/aws 2 cluster to TF 0.13/aws 3 you currently have to manually edit the state file to delete removed attributes. Should be fixed in v0.13.1 hashicorp/terraform#25779 . For the basic example I had to remove the following attributes:

• data aws_availability_zones: blacklisted_names and blackedlisted_zone_ids
• aws_iam_instance_profile: roles (Module Issues w/ Terraform v0.13.0 #974)

You also need to mess around with replace-provider a lot:

terraform state replace-provider -- -/aws hashicorp/aws
terraform state replace-provider -- -/kubernetes hashicorp/kubernetes
terraform state replace-provider -- -/local hashicorp/local
terraform state replace-provider -- -/null hashicorp/null
terraform state replace-provider -- -/random hashicorp/random
terraform state replace-provider -- -/template hashicorp/template

Checklist

• CI tests are passing
• README.md has been updated after any changes to variables and outputs. See https://github.com/terraform-aws-modules/terraform-aws-eks/#doc-generation

[daroga0002]

@dpiddockcmp looks Terraform 13.1 was released so should solve mentioned bug

https://github.com/hashicorp/terraform/releases/tag/v0.13.1

[dpiddockcmp]

@barryib are we good to merge this?

[barryib]

Please let me test this tonight with TF 0.13.1

[barryib]

@dpiddockcmp LGTM. Just tested an upgrade TF 0.12 to TF 0.13.1 without error. Shouldn't we change the Terraform required version to avoid TF 0.13.0 ("~> 0.12.9, >= 0.13.1") ?

[dpiddockcmp]

That version constraint can't be met. It can't be 0.12.* and greater than 0.13.0. Could use >= 0.12.9, != 0.13.0

[barryib]

That version constraint can't be met. It can't be 0.12.* and greater than 0.13.0. Could use >= 0.12.9, != 0.13.0

Ok. LGTM.

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.