Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

resource/kubernetes_limit_range: Avoid spurious diff when spec is empty #132

Merged
merged 1 commit into from
Mar 1, 2018
Merged

resource/kubernetes_limit_range: Avoid spurious diff when spec is empty #132

merged 1 commit into from
Mar 1, 2018

Conversation

radeksimko
Copy link
Member

Before

=== RUN   TestAccKubernetesLimitRange_empty
--- FAIL: TestAccKubernetesLimitRange_empty (0.07s)
	testing.go:513: Step 0 error: Check failed: 1 error(s) occurred:

		* Check 11/11 error: kubernetes_limit_range.test: Attribute 'spec.#' expected "0", got "1"
FAIL
FAIL	github.com/terraform-providers/terraform-provider-kubernetes/kubernetes	0.148s

After

=== RUN   TestAccKubernetesLimitRange_empty
--- PASS: TestAccKubernetesLimitRange_empty (0.09s)
PASS
ok  	github.com/terraform-providers/terraform-provider-kubernetes/kubernetes	0.179s

@radeksimko radeksimko added the bug label Mar 1, 2018
@radeksimko radeksimko requested a review from a team March 1, 2018 12:29
mbfrahry
mbfrahry approved these changes Mar 1, 2018
View reviewed changes
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@radeksimko radeksimko merged commit 93dca48 into master Mar 1, 2018
@radeksimko radeksimko deleted the b-lr-empty-spec branch March 1, 2018 22:20
@ghost ghost locked and limited conversation to collaborators Apr 21, 2020
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers

@mbfrahry mbfrahry mbfrahry approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@radeksimko @mbfrahry