Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

License Datasource #1580

Merged
merged 5 commits into from
Feb 11, 2022
Merged

License Datasource #1580

merged 5 commits into from
Feb 11, 2022

Conversation

appilon
Copy link
Contributor

@appilon appilon commented Feb 10, 2022 •
edited
Loading

Accidentally messed up the original PR #1488. I was fixing the vendor folder change sorry about that everyone

cc @andybaran

andybaran and others added 4 commits February 10, 2022 18:08
@andybaran @appilon
vsphere_license data source (#2)
eeb2ea8 
Addition of a data source for vsphere licenses.
@andybaran @appilon
cleanup before PR
14fd898
@appilon
Update data_source_vsphere_license.go
5a3df35 
Places `Id` under computed values.

Signed-off-by: Ryan Johnson <johnsonryan@vmware.com>
@appilon
Update license.html.markdown
ed0bc4b 
- Renames to `license.html.markdown` to match resource.
- Sets subcategory to `Administration`.
- Minor text updates.

Signed-off-by: Ryan Johnson <johnsonryan@vmware.com>
@github-actions github-actions bot added dependencies Type: Dependencies documentation Type: Documentation provider Type: Provider size/l Relative Sizing: Large labels Feb 10, 2022
@appilon appilon mentioned this pull request Feb 10, 2022
Closed
2 tasks
@appilon
Copy link
Contributor Author

appilon commented Feb 11, 2022

I made some changes to the implementation to make the schema correct for a datasource (no need for forcenew, labels are computed not optional). The acceptance tests ran successfully 🎉

➜ make testacc TESTARGS='-run=TestAccDataSourceVSphereLicense_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v -run=TestAccDataSourceVSphereLicense_basic -timeout 240m
?   	github.com/hashicorp/terraform-provider-vsphere	[no test files]
=== RUN   TestAccDataSourceVSphereLicense_basic
--- PASS: TestAccDataSourceVSphereLicense_basic (17.91s)
PASS

@appilon appilon merged commit 9a93589 into master Feb 11, 2022
@appilon appilon deleted the license branch February 11, 2022 02:56
@tenthirtyam
Copy link
Collaborator

Awesome, @appilon and @andybaran! 🎉

@tenthirtyam tenthirtyam added this to the v2.1.0 milestone Feb 14, 2022
@github-actions
Copy link

github-actions bot commented Mar 2, 2022

This functionality has been released in v2.1.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Apr 2, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 2, 2022
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers
No reviews
Assignees
No one assigned
Labels
dependencies Type: Dependencies documentation Type: Documentation provider Type: Provider size/l Relative Sizing: Large
Projects
None yet
Milestone
v2.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@appilon @tenthirtyam @andybaran