Update r/vsphere_file resource and docs

[tenthirtyam]

Description

• Updates the r/vsphere_file docs content and examples.
• Removed the code to remove the temporary directory where the VMDK is uploaded as this is automatically deleted as part of the VMDK move.

Plan:

provider "vsphere" {
  vsphere_server       = var.vsphere_server
  user                 = var.vsphere_username
  password             = var.vsphere_password
  allow_unverified_ssl = var.vsphere_insecure
}

resource "vsphere_file" "upload" {
  datacenter         = "m01-dc01"
  datastore          = "local-hdd-01"
  source_file        = "/Users/johnsonryan/Downloads/VMware-Appliance-FaH_1.0.5.vmdk"
  destination_file   = "/muffin/VMware-Appliance-FaH_1.0.5.vmdk"
  create_directories = true
}

Apply:

% terraform apply -auto-approve  

Terraform used the selected providers to generate the following execution plan. Resource actions are
indicated with the following symbols:
  + create

Terraform will perform the following actions:

  # vsphere_file.upload will be created
  + resource "vsphere_file" "upload" {
      + create_directories = true
      + datacenter         = "m01-dc01"
      + datastore          = "local-hdd-01"
      + destination_file   = "/muffin/VMware-Appliance-FaH_1.0.5.vmdk"
      + id                 = (known after apply)
      + source_file        = "/Users/johnsonryan/Downloads/VMware-Appliance-FaH_1.0.5.vmdk"
    }

Plan: 1 to add, 0 to change, 0 to destroy.
vsphere_file.upload: Creating...
vsphere_file.upload: Still creating... [10s elapsed]
vsphere_file.upload: Still creating... [20s elapsed]
vsphere_file.upload: Still creating... [30s elapsed]
vsphere_file.upload: Still creating... [40s elapsed]
vsphere_file.upload: Still creating... [50s elapsed]
vsphere_file.upload: Still creating... [1m0s elapsed]
vsphere_file.upload: Still creating... [1m10s elapsed]
vsphere_file.upload: Still creating... [1m20s elapsed]
vsphere_file.upload: Still creating... [1m30s elapsed]
vsphere_file.upload: Still creating... [1m40s elapsed]
vsphere_file.upload: Still creating... [1m50s elapsed]
vsphere_file.upload: Still creating... [2m0s elapsed]
vsphere_file.upload: Still creating... [2m10s elapsed]
vsphere_file.upload: Still creating... [2m20s elapsed]
vsphere_file.upload: Still creating... [2m30s elapsed]
vsphere_file.upload: Still creating... [2m40s elapsed]
vsphere_file.upload: Still creating... [2m50s elapsed]
vsphere_file.upload: Still creating... [3m0s elapsed]
vsphere_file.upload: Creation complete after 3m9s [id=[local-hdd-01] m01-dc01//muffin/VMware-Appliance-FaH_1.0.5.vmdk]

Apply complete! Resources: 1 added, 0 changed, 0 destroyed.

Destroy:

% terraform destroy -auto-approve
vsphere_file.upload: Refreshing state... [id=[local-hdd-01] m01-dc01//muffin/VMware-Appliance-FaH_1.0.5.vmdk]

Terraform used the selected providers to generate the following execution plan. Resource actions are
indicated with the following symbols:
  - destroy

Terraform will perform the following actions:

  # vsphere_file.upload will be destroyed
  - resource "vsphere_file" "upload" {
      - create_directories = true -> null
      - datacenter         = "m01-dc01" -> null
      - datastore          = "local-hdd-01" -> null
      - destination_file   = "/muffin/VMware-Appliance-FaH_1.0.5.vmdk" -> null
      - id                 = "[local-hdd-01] m01-dc01//muffin/VMware-Appliance-FaH_1.0.5.vmdk" -> null
      - source_file        = "/Users/johnsonryan/Downloads/VMware-Appliance-FaH_1.0.5.vmdk" -> null
    }

Plan: 0 to add, 0 to change, 1 to destroy.
vsphere_file.upload: Destroying... [id=[local-hdd-01] m01-dc01//muffin/VMware-Appliance-FaH_1.0.5.vmdk]
vsphere_file.upload: Destruction complete after 0s

Destroy complete! Resources: 1 destroyed.

References

Closes #1587

[appilon]

small edits, otherwise LGTM assuming the deleted cleanup code is okay

[tenthirtyam]

Recommend changes committed and question answered!

[github-actions]

This functionality has been released in v2.1.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.