-
Notifications
You must be signed in to change notification settings - Fork 455
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add tag category validation #1602
Conversation
attribute will now error if incorrect type is listed, also remove mention of "All" as it never appeared to work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
I added comments regarding including constants for each type (but it's not a requirement) and future methods to consider that could mask the API (e.g. com.vmware.content.library.Item
) from the user with simpler terms.
This functionality has been released in v2.1.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Description
Perform runtime validation of tag category associable types (since validate funcs don't work on aggregate types)
Acceptance tests
Output from acceptance testing:
Release Note
Release note for CHANGELOG:
References
Closes #1445