Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Revert type change of vsan_disk_group #1615

Merged
merged 2 commits into from
Mar 8, 2022
Merged

Revert type change of vsan_disk_group #1615

merged 2 commits into from
Mar 8, 2022

Conversation

appilon
Copy link
Contributor

@appilon appilon commented Mar 8, 2022

Reverts change from #1432 as it was an accidental breaking change from a configuration perspective, it also caused the provider to panic since the type assertions were not updated correctly. We have re-opened #1205 and will address it for v3.0.0 of the provider.

@github-actions github-actions bot added documentation Type: Documentation provider Type: Provider size/xs Relative Sizing: Extra-Small labels Mar 8, 2022
@appilon appilon force-pushed the revert-vsan-disk-group branch from 2b400db to 75149fb Compare March 8, 2022 02:25
@appilon appilon force-pushed the revert-vsan-disk-group branch from 75149fb to 08b0c4e Compare March 8, 2022 02:26
@appilon appilon changed the title Revert vsan disk group Revert type change of vsan_disk_group Mar 8, 2022
Copy link
Collaborator

@tenthirtyam tenthirtyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Alex!

@appilon appilon merged commit f4930ac into main Mar 8, 2022
@appilon appilon deleted the revert-vsan-disk-group branch March 8, 2022 15:44
@tenthirtyam tenthirtyam added this to the v2.1.1 milestone Mar 8, 2022
@github-actions
Copy link

This functionality has been released in v2.1.1 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Apr 9, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 9, 2022
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
documentation Type: Documentation provider Type: Provider size/xs Relative Sizing: Extra-Small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants