Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: Support looking up VM by UUID #1650

Merged
merged 2 commits into from
Apr 14, 2022
Merged

feat: Support looking up VM by UUID #1650

merged 2 commits into from
Apr 14, 2022

Conversation

appilon
Copy link
Contributor

@appilon appilon commented Apr 13, 2022

Description

Support lookup by UUID on the VM datasource.

Acceptance tests

  • Have you added an acceptance test for the functionality being added?
  • Have you run the acceptance tests on this branch?

Output from acceptance testing:

➜ make testacc TESTARGS='-run=TestAccDataSourceVSphereVirtualMachine_' GOFLAGS="-count=1"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v -run=TestAccDataSourceVSphereVirtualMachine_ -timeout 240m
?   	github.com/hashicorp/terraform-provider-vsphere	[no test files]
=== RUN   TestAccDataSourceVSphereVirtualMachine_basic
--- PASS: TestAccDataSourceVSphereVirtualMachine_basic (32.52s)
=== RUN   TestAccDataSourceVSphereVirtualMachine_noDatacenterAndAbsolutePath
--- PASS: TestAccDataSourceVSphereVirtualMachine_noDatacenterAndAbsolutePath (30.32s)
=== RUN   TestAccDataSourceVSphereVirtualMachine_uuid
--- PASS: TestAccDataSourceVSphereVirtualMachine_uuid (34.00s)
PASS

Release Note

Release note for CHANGELOG:

d/virtual_machine: support lookup by `uuid`

References

Closes #1612

@appilon appilon requested a review from tenthirtyam April 13, 2022 19:32
@github-actions github-actions bot added provider Type: Provider size/m Relative Sizing: Medium labels Apr 13, 2022
@appilon appilon added area/vm Area: Virtual Machines feature and removed size/m Relative Sizing: Medium provider Type: Provider labels Apr 13, 2022
@appilon appilon added this to the v2.2.0 milestone Apr 13, 2022
@github-actions github-actions bot added documentation Type: Documentation provider Type: Provider size/m Relative Sizing: Medium labels Apr 13, 2022
@appilon appilon changed the title feature: Support looking up VM by UUID feat: Support looking up VM by UUID Apr 13, 2022
Copy link
Collaborator

@tenthirtyam tenthirtyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @appilon!

@appilon appilon merged commit 296ae2e into main Apr 14, 2022
@appilon appilon deleted the gh-1612 branch April 14, 2022 16:04
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 15, 2022
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
area/vm Area: Virtual Machines documentation Type: Documentation provider Type: Provider size/m Relative Sizing: Medium
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for UUID field in d/virtual_machine
2 participants