fix: import of r/vsphere_virtual_disk imports the wrong vmdk_path

[zxinyu08]

Description

Fix: Import of r/vsphere_virtual_disk imports the wrong vmdk_path.

Acceptance tests

• Have you added an acceptance test for the functionality being added?
• Have you run the acceptance tests on this branch?

Output from local testing:

$rm terraform.tfstate
$terraform import vsphere_virtual_disk.vmdk '{"virtual_disk_path": "/DataCenter/[vsanDatastore]namespace_test/secondary.vmdk", "create_directories": "true"}'
...
vsphere_virtual_disk.vmdk: Importing from ID "{\"virtual_disk_path\": \"/DataCenter/[vsanDatastore]namespace_test/secondary.vmdk\", \"create_directories\": \"true\"}"...
2022-09-26T19:23:44.709-0700 [INFO]  provider.terraform-provider-vsphere: 2022/09/26 19:23:44 [INFO] Set create_directories during import: true: timestamp=2022-09-26T19:23:44.709-0700   <----newly added log info, field is successfully set during import
2022-09-26T19:23:45.164-0700 [INFO]  provider.terraform-provider-vsphere: 2022/09/26 19:23:45 [DEBUG] DatastorePathFromString: success: true, path: "[vsanDatastore] 795e3263-e238-26e7-a8c6-02008e76a48b/secondary.vmdk": timestamp=2022-09-26T19:23:45.164-0700
vsphere_virtual_disk.vmdk: Import prepared!
  Prepared vsphere_virtual_disk for import
vsphere_virtual_disk.vmdk: Refreshing state... [id=namespace_test/secondary.vmdk]
....
Import successful!

The resources that were imported are shown above. These resources are now in
your Terraform state and will henceforth be managed by Terraform.

$cat terraform.tfstate
{
  "version": 4,
  "terraform_version": "1.2.1",
  "serial": 1,
  "lineage": "54097c80-aeff-a51b-a5d2-7c91fca8daa5",
  "outputs": {},
  "resources": [
    {
      "mode": "managed",
      "type": "vsphere_virtual_disk",
      "name": "vmdk",
      "provider": "provider[\"terraform-example.com/provider/vsphere\"]",
      "instances": [
        {
          "schema_version": 0,
          "attributes": {
            "adapter_type": "lsiLogic",
            "create_directories": true,  <--- set to true after import
            "datacenter": "DataCenter",
            "datastore": "vsanDatastore",
            "id": "namespace_test/secondary.vmdk",  <--- change to readable name, same as former tfstate file
            "size": 500,
            "type": "thin",
            "vmdk_path": "namespace_test/secondary.vmdk". <--- change to readable name, same as former tfstate file
          },
          "sensitive_attributes": [],
          "private": "eyJzY2hlbWFfdmVyc2lvbiI6IjAifQ=="
        }
      ]
    }
  ]
}
$terraform plan
....
2022-09-26T19:24:07.894-0700 [DEBUG] no planned changes, skipping apply graph check
2022-09-26T19:24:07.894-0700 [INFO]  backend/local: plan operation completed

No changes. Your infrastructure matches the configuration.

Terraform has compared your real infrastructure against your configuration and found no differences, so no changes are needed.

Local test without create_directories field was also done. Import won't be blocked, and the issue is expected to be reproed.

Release Note

Release note for CHANGELOG:

resource/virtual_disk: Update import usage

References

Closes #1482

[tenthirtyam]

LGTM! 🚀 - awaiting review from @appilon

[appilon]

Hello @zxinyu08 this is a very creative solution. I'm going to take a look at the issue though #1482 to see if we can solve this problem more conventionally.

[zxinyu08]

Sure, conventional one could be much better, thanks @appilon.

Will reviewed again to see if this can be solved more conventionally.

[tenthirtyam]

LGTM! I'd rather get this one in as-is versus refactor and delay.

[github-actions]

This functionality has been released in v2.7.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.