Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Robustly check nil for all vsan data #1835

Merged
merged 1 commit into from
Feb 8, 2023
Merged

Robustly check nil for all vsan data #1835

merged 1 commit into from
Feb 8, 2023

Conversation

appilon
Copy link
Contributor

@appilon appilon commented Feb 8, 2023

Description

Acceptance tests

  • Have you added an acceptance test for the functionality being added?
  • Have you run the acceptance tests on this branch?

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

(all pass)

Release Note

Release note for CHANGELOG:

`resource/compute_cluster`: Fix panic. [GH-1835]

References

@github-actions github-actions bot added provider Type: Provider size/s Relative Sizing: Small labels Feb 8, 2023
@appilon appilon requested a review from a team February 8, 2023 22:11
Copy link

@megan07 megan07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@appilon appilon merged commit e9c442e into main Feb 8, 2023
@appilon appilon deleted the fix-panic branch February 8, 2023 22:14
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 11, 2023
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
provider Type: Provider size/s Relative Sizing: Small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants