Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: vnic tests #1887

Merged
merged 2 commits into from
Apr 19, 2023
Merged

fix: vnic tests #1887

merged 2 commits into from
Apr 19, 2023

Conversation

appilon
Copy link
Contributor

@appilon appilon commented Apr 19, 2023

Description

Fix VNIC tests to work with new nested ESXi model. This is so I can review/add tests to #1855

Acceptance tests

  • Have you added an acceptance test for the functionality being added?
  • Have you run the acceptance tests on this branch?

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccResourceVSphereVNic_'
=== RUN   TestAccResourceVSphereVNic_dvs_default
--- PASS: TestAccResourceVSphereVNic_dvs_default (196.88s)
=== RUN   TestAccResourceVSphereVNic_dvs_vmotion
--- PASS: TestAccResourceVSphereVNic_dvs_vmotion (196.36s)
=== RUN   TestAccResourceVSphereVNic_hvs_default
--- PASS: TestAccResourceVSphereVNic_hvs_default (33.19s)
=== RUN   TestAccResourceVSphereVNic_hvs_vmotion
--- PASS: TestAccResourceVSphereVNic_hvs_vmotion (32.19s)

Release Note

Release note for CHANGELOG:

r/vsphere_vnic: Fix vnic tests GH-1887

References

Add second NIC to nested ESXI to allow vnic tests to run. Fix bug in
ipv6 logic (those config/check generators need to be rewritten).
@appilon appilon requested a review from a team as a code owner April 19, 2023 22:05
@appilon appilon requested a review from tenthirtyam April 19, 2023 22:05
@github-actions github-actions bot added provider Type: Provider size/s Relative Sizing: Small labels Apr 19, 2023
@github-actions github-actions bot added the documentation Type: Documentation label Apr 19, 2023
Copy link
Collaborator

@tenthirtyam tenthirtyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@appilon appilon merged commit d2c0fb2 into main Apr 19, 2023
@appilon appilon deleted the fix-vnic-tests branch April 19, 2023 22:31
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 20, 2023
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
documentation Type: Documentation provider Type: Provider size/s Relative Sizing: Small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants