fix: file names with special chars

[tenthirtyam]

Description

Updates r/file to ensure that incoming file names with special characters (+, specifically) retain their original name when uploaded so that the plan is consistent.

Testing

➜ terraform apply -auto-approve          
data.vsphere_datacenter.datacenter: Reading...
data.vsphere_datacenter.datacenter: Read complete after 0s [id=datacenter-3]
data.vsphere_datastore.datastore: Reading...
data.vsphere_datastore.datastore: Read complete after 0s [id=datastore-18076]

Terraform used the selected providers to generate the following execution plan. Resource actions are indicated with the following symbols:
  + create

Terraform will perform the following actions:

  # vsphere_file.iso will be created
  + resource "vsphere_file" "iso" {
      + create_directories = true
      + datacenter         = "m01-dc01"
      + datastore          = "local-ssd-01"
      + destination_file   = "test/test-1.0.0+1.iso"
      + id                 = (known after apply)
      + source_file        = "/Users/johnsonryan/Library/Mobile Documents/com~apple~CloudDocs/Code/Work/terrafom-examples-vmware/vsphere/vsphere-virtual-machine/clone-ovf-esxi-simple/test-1.0.0+1.iso"
    }

  # vsphere_file.isoa will be created
  + resource "vsphere_file" "isoa" {
      + create_directories = true
      + datacenter         = "m01-dc01"
      + datastore          = "local-ssd-01"
      + destination_file   = "test/test-2.0.0+2.iso"
      + id                 = (known after apply)
      + source_file        = "/Users/johnsonryan/Library/Mobile Documents/com~apple~CloudDocs/Code/Work/terrafom-examples-vmware/vsphere/vsphere-virtual-machine/clone-ovf-esxi-simple/test-2.0.0.iso"
    }

Plan: 2 to add, 0 to change, 0 to destroy.
vsphere_file.isoa: Creating...
vsphere_file.iso: Creating...
vsphere_file.iso: Creation complete after 0s [id=[local-ssd-01] m01-dc01/test/test-1.0.0+1.iso]
vsphere_file.isoa: Creation complete after 0s [id=[local-ssd-01] m01-dc01/test/test-2.0.0+2.iso]

Apply complete! Resources: 2 added, 0 changed, 0 destroyed.

terrafom-examples-vmware/vsphere/vsphere-virtual-machine/clone-ovf-esxi-simple on  main [✘!?] took 3.3s 
➜ terraform destroy -auto-approve        
data.vsphere_datacenter.datacenter: Reading...
data.vsphere_datacenter.datacenter: Read complete after 0s [id=datacenter-3]
data.vsphere_datastore.datastore: Reading...
data.vsphere_datastore.datastore: Read complete after 1s [id=datastore-18076]
vsphere_file.iso: Refreshing state... [id=[local-ssd-01] m01-dc01/test/test-1.0.0+1.iso]
vsphere_file.isoa: Refreshing state... [id=[local-ssd-01] m01-dc01/test/test-2.0.0+2.iso]

Terraform used the selected providers to generate the following execution plan. Resource actions are indicated with the following symbols:
  - destroy

Terraform will perform the following actions:

  # vsphere_file.iso will be destroyed
  - resource "vsphere_file" "iso" {
      - create_directories = true -> null
      - datacenter         = "m01-dc01" -> null
      - datastore          = "local-ssd-01" -> null
      - destination_file   = "test/test-1.0.0+1.iso" -> null
      - id                 = "[local-ssd-01] m01-dc01/test/test-1.0.0+1.iso" -> null
      - source_file        = "/Users/johnsonryan/Library/Mobile Documents/com~apple~CloudDocs/Code/Work/terrafom-examples-vmware/vsphere/vsphere-virtual-machine/clone-ovf-esxi-simple/test-1.0.0+1.iso" -> null
    }

  # vsphere_file.isoa will be destroyed
  - resource "vsphere_file" "isoa" {
      - create_directories = true -> null
      - datacenter         = "m01-dc01" -> null
      - datastore          = "local-ssd-01" -> null
      - destination_file   = "test/test-2.0.0+2.iso" -> null
      - id                 = "[local-ssd-01] m01-dc01/test/test-2.0.0+2.iso" -> null
      - source_file        = "/Users/johnsonryan/Library/Mobile Documents/com~apple~CloudDocs/Code/Work/terrafom-examples-vmware/vsphere/vsphere-virtual-machine/clone-ovf-esxi-simple/test-2.0.0.iso" -> null
    }

Plan: 0 to add, 0 to change, 2 to destroy.
vsphere_file.iso: Destroying... [id=[local-ssd-01] m01-dc01/test/test-1.0.0+1.iso]
vsphere_file.isoa: Destroying... [id=[local-ssd-01] m01-dc01/test/test-2.0.0+2.iso]
vsphere_file.isoa: Destruction complete after 1s
vsphere_file.iso: Destruction complete after 1s

Destroy complete! Resources: 2 destroyed.

Reference

Closes #1928

[github-actions]

This functionality has been released in v2.8.2 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!