Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

docs: remove interpolation syntax #2220

Merged
merged 1 commit into from
Jun 20, 2024
Merged

Conversation

tenthirtyam
Copy link
Collaborator

Description

Removes deprecated interpolation syntax where it is no longer required.

Example

From:

data "vsphere_host" "hosts" {
  count         = "${length(var.hosts)}"
  name          = "${var.hosts[count.index]}"
  datacenter_id = "${data.vsphere_datacenter.dc.id}"
}

To:

data "vsphere_host" "hosts" {
  count         = length(var.hosts)
  name          = var.hosts[count.index]
  datacenter_id = data.vsphere_datacenter.datacenter.id
}

@tenthirtyam tenthirtyam added the documentation Type: Documentation label Jun 17, 2024
@tenthirtyam tenthirtyam added this to the v2.8.2 milestone Jun 17, 2024
@tenthirtyam tenthirtyam self-assigned this Jun 17, 2024
@tenthirtyam tenthirtyam requested a review from a team as a code owner June 17, 2024 13:28
@github-actions github-actions bot added the needs-review Status: Pull Request Needs Review label Jun 17, 2024
Copy link
Collaborator

@spacegospod spacegospod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!
We should probably start cleaning up the syntax in the tests too

@tenthirtyam
Copy link
Collaborator Author

Nice! We should probably start cleaning up the syntax in the tests too

Yes - 100%! That was the next on the list for me - quite extensive. 😄 💯

@tenthirtyam tenthirtyam requested a review from appilon June 18, 2024 14:27
Removes deprecated interpolation syntax where it is no longer required.

Signed-off-by: Ryan Johnson <ryan@tenthirtyam.org>
@tenthirtyam tenthirtyam force-pushed the docs/remove-interpolation-syntax branch from 26687c6 to 3465a4f Compare June 20, 2024 18:58
@tenthirtyam tenthirtyam merged commit cc9cacb into main Jun 20, 2024
5 checks passed
@tenthirtyam tenthirtyam deleted the docs/remove-interpolation-syntax branch June 20, 2024 19:01
Copy link

This functionality has been released in v2.8.2 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@hashicorp hashicorp locked as resolved and limited conversation to collaborators Jun 29, 2024
@tenthirtyam tenthirtyam removed the needs-review Status: Pull Request Needs Review label Aug 14, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
documentation Type: Documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants